Try starting Omnisharp server without solution file #1663
Conversation
|
@sankhesh can you given an example of a specific problem that this solves? @mispencer WDYT? |
|
@puremourning However, it is common for C# projects (Unity projects, for example) to not have a VS solution file to go with. Secondly, Onmisharp doesn't really require a solution file anymore. It just needs a working directory which is what the change provides. Hth |
sankhesh
force-pushed
the
empty_solution_omnisharp_server
branch
from
0a0fc8c to
3a708f9
Compare
|
Thanks, Can we please add a test directory and some tests that show it works? Hopefully just a simple project without a solution file and basic tests. We have test primitives for things like StartCompleterServerInDirectory or something. Otherwise, I'm likely to just break this as I don't c# often |
|
Yeah - the test failure in CI is related to this feature. I'll fix the tests so that it provides sufficient testing for this feature as well. Btw, can you label this PR as "hacktoberfest-accepted". Might as well :) |
I don't know what that means but if you need me to do something for you to earn internet points, then let me know and I guess I can do it if it isn't too much effort. |
|
Ah, I see. Hacktoberfest is a fun month-long fest that rewards open source contributors. To claim this PR as a valid contribution, a maintainer (I assume you're one) would need to label this PR with the text |
|
@Mergifyio rebase |
With this change, ycmd will attempt to start the Omnisharp server with the current working directory when no solution file is found. The runtime check for solution file presence is not required and exception raising is defered to Omnisharp.
- Change the test to ensure that the OmniSharp server starts with an empty solution file. - Remove the test that was testing that the case where OmniSharp server should not start when an unambiguous solution file is not found.
Valloric
force-pushed
the
empty_solution_omnisharp_server
branch
from
f4bd725 to
fa3bdab
Compare
|
To get the future behavior now, you can configure Or you can create a dedicated github account for squash and rebase operations, and use it in different |
✅ Branch has been successfully rebased |
|
@Mergifyio rebase |
❌ Unable to rebase: user
|
With this change, ycmd will attempt to start the Omnisharp server with the current working directory when no solution file is found. The runtime check for solution file presence is not required and exception raising is defered to Omnisharp.
This change is