-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress pandas FutureWarnings #165
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Thanks, but the better solution would be to just replace |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 4 4
Lines 277 277
=======================================
Hits 261 261
Misses 16 16 ☔ View full report in Codecov by Sentry. |
looks great thanks. but why are you also changing the minimum python version from 3.8 to 3.9? |
Sorry but Python 3.8 is still not end-of-life, I don't think we can drop support for it by requiring Python 3.9+ |
@yehoshuadimarsky That's fair enough. Since we can't use |
I'm sorry, why can't |
3.8 went EOL two weeks ago. |
Sorry this took so long, it took me a while to get all the versions of pandas numpy and python to work with each other, finally dropped support for python 3.8 and added 3.12+ here #218. I hope this unblocks you, feel free to update your PR now. Note, I recently changed the build system to use |
Fixes #156.