Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

options.copy work with tests, this time as single commit #38

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mwillerich
Copy link

This PR is nearly identical to #31. In this PR it comes as a single commit, and I also changed some whitespace formatting in the test.

@mwillerich
Copy link
Author

@eddiemonge here's my newest attempt.

@eddiemonge
Copy link
Member

hmm the tests are failing

@eddiemonge
Copy link
Member

oh yeah, i know why. let me fix those first

stephanebachelier added a commit to stephanebachelier/grunt-filerev that referenced this pull request Nov 13, 2014
Make tests more robusts as there is a test in Gruntfile and should help
the PR yeoman#38
@stephanebachelier
Copy link
Contributor

@eddiemonge I think the #65 should fix the test.

@mwillerich you may wait for #65 to be merged or rebase on top of master.

@arthurvr
Copy link
Member

arthurvr commented Jun 7, 2015

Tests work fine these days. Can you rebase this, @mwillerich?

@OliverKK
Copy link

OliverKK commented Oct 7, 2015

Why is this PR not in master? I think it's quite handy to keep the originals.

@arthurvr
Copy link
Member

arthurvr commented Oct 7, 2015

Because it needs a rebase.

Can you rebase this, @mwillerich?

@mwillerich
Copy link
Author

hi @arthurvr, apologies about the delay. I'll try tonight.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants