Skip to content

Commit

Permalink
test: Don't check for the exact size of compressed content.
Browse files Browse the repository at this point in the history
The testsuite checks for the exact size of the compressed content. The
exact size can change if the zlib library is using a different strategy.
In thise case using zlib-ng results in a slightly larger content leading
to a failure in the test.

Check that the compressed content is less than 10MiB which is a tenth of
the orignal content and proves that compression works.

Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
  • Loading branch information
sebastianas authored and Sebastian Andrzej Siewior committed Nov 25, 2024
1 parent 4139949 commit 81c1a85
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test/test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4258,7 +4258,9 @@ TEST_F(ServerTest, PutLargeFileWithGzip2) {
ASSERT_TRUE(res);
EXPECT_EQ(StatusCode::OK_200, res->status);
EXPECT_EQ(LARGE_DATA, res->body);
EXPECT_EQ(101942u, res.get_request_header_value_u64("Content-Length"));
// The compressed size should be less than a 10th of the original. May vary
// depending on the zlib library.
EXPECT_LT(res.get_request_header_value_u64("Content-Length"), 10 * 1024 * 1024);
EXPECT_EQ("gzip", res.get_request_header_value("Content-Encoding"));
}

Expand Down

0 comments on commit 81c1a85

Please sign in to comment.