-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor DMLQueryBuilder #746
Conversation
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #746 +/- ##
============================================
- Coverage 99.21% 99.05% -0.17%
+ Complexity 1272 1260 -12
============================================
Files 67 67
Lines 3072 3059 -13
============================================
- Hits 3048 3030 -18
- Misses 24 29 +5
☔ View full report in Codecov by Sentry. |
Remove following methods from
They all throw the exceprion Or are they needed for future implementations? |
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
Refactoring with:
upsert()
test['{{%type}}.[[int_col]]', '[[float_col]]']
wrongBehaviorbatchInsert()
if values with string keys Batchinsert and associative arrays #61 (point 2)batchInsert()
,insert()
,update()
,upsert()
allow columns of the passed table only Different tables in columns #744Related PRs