Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate column type constants #877

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Separate column type constants #877

merged 2 commits into from
Sep 13, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Sep 8, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Sep 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (e6382dd) to head (720ae20).

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #877   +/-   ##
=========================================
  Coverage     99.61%   99.61%           
  Complexity     1389     1389           
=========================================
  Files            75       75           
  Lines          3405     3405           
=========================================
  Hits           3392     3392           
  Misses           13       13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Sep 8, 2024
Merged
Merged
Merged
Merged
Merged
vjik
vjik approved these changes Sep 8, 2024
View reviewed changes
src/Schema/SchemaInterface.php
@@ -121,106 +123,158 @@ interface SchemaInterface extends ConstraintSchemaInterface
public const INDEX_BITMAP = 'BITMAP';
/**
* Define the abstract column type as a primary key.
*
* @deprecated Use {@see PseudoType::PK} instead. Will be removed in 2.0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After PR merge add this to #824

@Tigrov Tigrov merged commit e3e277d into master Sep 13, 2024
3 checks passed
@Tigrov Tigrov deleted the separate-constants branch September 13, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tigrov @vjik