Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add romanian language #362

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add romanian language #362

wants to merge 4 commits into from

Conversation

mrbig00
Copy link

@mrbig00 mrbig00 commented Oct 10, 2021

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

resources/messages/ro/app.php Outdated Show resolved Hide resolved
resources/messages/ro/app.php Outdated Show resolved Hide resolved
Copy link
Author

@mrbig00 mrbig00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the mentioned errors

@vjik
Copy link
Member

vjik commented Oct 11, 2021

Are you tested application with this translate?
Seems need add language to select...

@samdark samdark added the status:under development Someone is working on a pull request. label Oct 18, 2021
@mrbig00
Copy link
Author

mrbig00 commented Oct 19, 2021

It seems that the language selector is not changing the app language, not even on the master branch

@vjik
Copy link
Member

vjik commented Oct 19, 2021

It seems that the language selector is changing the app language, not even on the master branch

Try add new language here:

'ru' => $this->translator->translate('layout.language.russian'),

@xepozz
Copy link
Contributor

xepozz commented Oct 1, 2022

@mrbig00 would you like to complete the pr?

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 31.58% // Head: 31.58% // No change to project coverage 👍

Coverage data is based on head (f4fa529) compared to base (1e629a1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #362   +/-   ##
=========================================
  Coverage     31.58%   31.58%           
  Complexity      340      340           
=========================================
  Files            56       56           
  Lines          1127     1127           
=========================================
  Hits            356      356           
  Misses          771      771           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:under development Someone is working on a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants