Environments #445
Open
Environments #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rustamwin
commented
Mar 14, 2022
rustamwin
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️/❌ |
| New feature? | ✔️/❌ |
| Breaks BC? | ✔️/❌ |
| Fixed issues | comma-separated list of tickets # fixed by the PR, if any |
vjik
reviewed
Mar 26, 2022
| return \filter_var(self::$values[$name] ?? null, FILTER_VALIDATE_INT, FILTER_NULL_ON_FAILURE) ?? $default; | ||
| } | ||
|
|
||
| public static function load(): void |
There was a problem hiding this comment.
Maybe move this method to separate class? In most cases this method will be unnecessary in IDE autocompletion on Env::.
samdark
approved these changes
Mar 30, 2022
|
We need to discuss whether environment variables should be cached. |
|
What's the purpose of caching them? |
|
The advantage of the env variables that they can be changed on the fly. Without that you may use simple php array to store such variables |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.