Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading files via Contact form #491

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Uploading files via Contact form #491

merged 1 commit into from
Aug 8, 2022

Conversation

githubjeka
Copy link
Contributor

Added missed multipart/form-data
Added missed multiple name attribute
Closing DIV tag matches nothing

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Added missed multipart/form-data
Added missed multiple name attribute
Closing DIV tag matches nothing
@rustamwin rustamwin added type:bug Bug status:code review The pull request needs review. labels Aug 4, 2022
@rustamwin rustamwin requested a review from a team August 4, 2022 06:44
@arogachev arogachev changed the title Uploading files via Contract form Uploading files via Contact form Aug 8, 2022
@arogachev
Copy link
Contributor

arogachev commented Aug 8, 2022

Tested it with running app, the error

`TypeError`
Cannot assign string to property `App\Contact\ContactForm::$attachFiles` of type `?array `

is gone.

But now the handling needs to be fixed too:

`Error`
Call to a member function `getStream()` on array 

Can be done in a separate PR though. Maybe #438 is related.

Thanks.

@arogachev arogachev merged commit d48f3e0 into yiisoft:master Aug 8, 2022
@githubjeka githubjeka deleted the upload-contract branch August 8, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review. type:bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants