Adjust hierarchy when removing item

CHANGELOG.md

@@ -49,6 +49,7 @@
 - Enh #204: Add simple storages for items and assignments (@arogachev)
 - Chg #217: Raise PHP version to 8.1 (@arogachev)
 - Bug #221: Exclude items with base names when getting children (@arogachev)
+- Bug #?: Adjust hierarchy when removing item (@arogachev) 
 
 ## 1.0.2 April 20, 2023
 

src/SimpleItemsStorage.php

@@ -257,6 +257,7 @@ private function updateChildrenForItemName(string $name, Item $item): void
             $this->children[$item->getName()] = $this->children[$name];
             unset($this->children[$name]);
         }
+
         foreach ($this->children as &$children) {
             if (isset($children[$name])) {
                 $children[$item->getName()] = $item;
@@ -268,6 +269,10 @@ private function updateChildrenForItemName(string $name, Item $item): void
     private function removeItemByName(string $name): void
     {
         unset($this->items[$name]);
+
+        foreach ($this->children as &$children) {
+            unset($children[$name]);
+        }
     }
 
     /**

tests/Common/ManagerLogicTestTrait.php

@@ -668,7 +668,7 @@ public function testRemoveRole(): void
         $this->assertNull($manager->getRole('reader'));
         $this->assertSame($manager, $returnedManager);
         $this->assertFalse($manager->userHasPermission('reader A', 'readPost'));
-        $this->assertEqualsCanonicalizing(['author B', 'admin C'], $manager->getUserIdsByRoleName('reader'));
+        $this->assertEqualsCanonicalizing([], $manager->getUserIdsByRoleName('reader'));
     }
 
     public function testUpdateRoleNameAndRule(): void