Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve filtering of items #211

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Improve filtering of items #211

merged 1 commit into from
Dec 6, 2023

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?

@arogachev arogachev self-assigned this Dec 6, 2023
@arogachev arogachev added the type:task Task label Dec 6, 2023
@arogachev arogachev merged commit 2d19bbb into master Dec 6, 2023
23 of 27 checks passed
@arogachev arogachev deleted the filter-items branch December 6, 2023 12:06
Copy link

what-the-diff bot commented Dec 6, 2023

PR Summary

  • Simplified Array Filtering in FakeItemsStorage.php
    The logic for filtering arrays in both filterRoles and filterPermissions methods has been improved. The old method, which relied on checking if an array key exists, has been replaced with a more straightforward approach: now it checks directly if an item is an instance of Role or Permission respectively. It will make the code more readable and easier to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant