Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SimpleAssignmentsStorage::$assignments protected #219

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Make SimpleAssignmentsStorage::$assignments protected #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ private function assertFutureChild(string $parentName, string $childName): void
throw new RuntimeException("Child \"$childName\" does not exist.");
}

if ($parent->getType() === Item::TYPE_PERMISSION && $child->getType() === Item::TYPE_ROLE) {
if ($parent instanceof Permission && $child instanceof Role) {
throw new RuntimeException(
"Can not add \"$childName\" role as a child of \"$parentName\" permission.",
);
Expand Down
2 changes: 1 addition & 1 deletion src/SimpleAssignmentsStorage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ abstract class SimpleAssignmentsStorage implements AssignmentsStorageInterface
/**
* @psalm-var array<string, array<string, Assignment>>
*/
private array $assignments = [];
protected array $assignments = [];

public function getAll(): array
{
Expand Down
Loading