Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude items with start names when getting children #221

Merged
merged 6 commits into from
Dec 15, 2023

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?

@arogachev arogachev self-assigned this Dec 14, 2023
@arogachev arogachev added the type:bug Bug label Dec 14, 2023
@arogachev arogachev added this to the 2.0 milestone Dec 14, 2023
Copy link

what-the-diff bot commented Dec 14, 2023

PR Summary

  • Additional Parameter to fillChildrenRecursive Method
    A new parameter named $names was incorporated into the fillChildrenRecursive method in the SimpleItemsStorage.php file. This modification allows the method to handle specific situations more effectively.

  • Optimization of Test Data in ItemsStorageTestTrait.php
    The data set used for testing in two methods, dataGetAllChildren and dataGetAllChildRoles, has been optimized. Redundant and non-essential elements were removed resulting in cleaner and more efficient input for testing within these methods.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17f569a) 100.00% compared to head (b246822) 100.00%.

❗ Current head b246822 differs from pull request most recent head 166875a. Consider uploading reports for the commit 166875a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #221   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       211       212    +1     
===========================================
  Files             13        13           
  Lines            525       527    +2     
===========================================
+ Hits             525       527    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev changed the title Exclude initial items when getting children Exclude items with start names when getting children Dec 15, 2023
@arogachev arogachev marked this pull request as ready for review December 15, 2023 06:21
@arogachev arogachev merged commit 934370c into master Dec 15, 2023
3 checks passed
@arogachev arogachev deleted the fix-chidren-recursion branch December 15, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant