Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust hierarchy when removing item #222

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Adjust hierarchy when removing item #222

merged 2 commits into from
Dec 18, 2023

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17f569a) 100.00% compared to head (71f7eb7) 100.00%.
Report is 3 commits behind head on master.

❗ Current head 71f7eb7 differs from pull request most recent head 34fc115. Consider uploading reports for the commit 34fc115 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #222   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       211       213    +2     
===========================================
  Files             13        13           
  Lines            525       529    +4     
===========================================
+ Hits             525       529    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Dec 18, 2023

PR Summary

  • Updated CHANGELOG.md File
    A new entry that talks about a recent bug fix has been added to our CHANGELOG.md file. This bug dealt with the incorrect hierarchical structure when removing specific items from our system.

  • Updated SimpleItemsStorage.php File

    • Improved code readability by adding a new line between different blocks of code.
    • Introduced a new feature that enables removing specific items from a list of child items, enhancing the way we manage items in our system.
  • Reworked ManagerLogicTestTrait.php File

    • The code block has been modified to ensure that the system shows an expected value as an empty array under certain conditions, further ensuring system stability and accurate data representation.

@arogachev arogachev merged commit 9d1f894 into master Dec 18, 2023
2 checks passed
@arogachev arogachev deleted the fix-remove-item branch December 18, 2023 12:07
@arogachev arogachev self-assigned this Dec 18, 2023
@arogachev arogachev added the type:bug Bug label Dec 18, 2023
@arogachev arogachev added this to the 2.0 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant