Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimpleRuleFactory #249

Merged
merged 11 commits into from
Feb 16, 2024
Merged

Add SimpleRuleFactory #249

merged 11 commits into from
Feb 16, 2024

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️

@arogachev arogachev self-assigned this Feb 13, 2024
@arogachev arogachev added the type:enhancement Enhancement label Feb 13, 2024
@arogachev arogachev added this to the 2.0 milestone Feb 13, 2024
Copy link

what-the-diff bot commented Feb 13, 2024

PR Summary

  • Added a New Entry to the Change Log
    A new update regarding the addition of SimpleRuleFactory is documented in the change log.
  • Moved the SimpleRuleFactory File to a New Location
    The test file SimpleRuleFactory.php, which is part of the support, has been moved to the source folder. This action is meant for better organization and easy access.
  • Updated File Imports in Test Suites
    The file imports in test suites ManagerConfigurationTestTrait.php and ManagerLogicTestTrait.php are modified to use the SimpleRuleFactory from a new location - Yiisoft\Rbac namespace.
  • Updated File Imports in Specific Tests
    The file imports in a few specific test files (CompositeRuleTest.php, ConfigTest.php, and RuleContextTest.php) are also updated to use SimpleRuleFactory from its new location.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98cf8d7) 100.00% compared to head (50d8b28) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #249   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       217       220    +3     
===========================================
  Files             13        14    +1     
  Lines            544       550    +6     
===========================================
+ Hits             544       550    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev marked this pull request as ready for review February 14, 2024 11:50
@arogachev arogachev requested a review from a team February 14, 2024 11:55
src/RuleContext.php Outdated Show resolved Hide resolved
@arogachev arogachev requested review from vjik and a team February 15, 2024 07:45
src/RuleContext.php Outdated Show resolved Hide resolved
@arogachev arogachev requested review from a team and vjik February 16, 2024 07:13
@arogachev arogachev merged commit 2204ce4 into master Feb 16, 2024
22 of 25 checks passed
@arogachev arogachev deleted the 248-simple-rules-factory branch February 16, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add implementation for RuleFactoryInterface that create rules via new $class.
3 participants