Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter User item names adding default items #263

Closed
wants to merge 1 commit into from
Closed

Filter User item names adding default items #263

wants to merge 1 commit into from

Conversation

KovYu
Copy link

@KovYu KovYu commented Apr 21, 2024

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌

@arogachev arogachev added the type:bug Bug label Apr 21, 2024
@arogachev arogachev linked an issue Apr 21, 2024 that may be closed by this pull request
Manager::userHasPermission() - default roles are not checked #264
Closed
arogachev
arogachev reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@arogachev arogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. See #265 for additions.

@arogachev arogachev added this to the 2.1 milestone Apr 22, 2024
@arogachev
Copy link
Contributor

Closed in favor of #265. I mentioned you in CHANGELOG. Thanks for discovering and implementation draft.

@arogachev arogachev closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arogachev arogachev arogachev left review comments

Assignees
No one assigned
Labels
type:bug Bug
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Manager::userHasPermission() - default roles are not checked
2 participants
@KovYu @arogachev