Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise min version to PHP 7.3, check compatibility PHP 8.3. #536

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 26, 2023

PR Summary

  • Build Workflow Update
    Our system's build workflow file, .github/workflows/build.yml, has been modified. This update means that certain files will be ignored during certain operations, optimizing our workflow and making the system more efficient.

  • Upgrade of Testing Tools
    We updated the version of phpunit/phpunit, which is the tool we use for testing, in composer.json file. This allows us to access new features, improvements, and bug-fixes from the updated tool, ensuring our tests are more reliable. Additionally, we have specified the least version of PHP our project supports is 7.3, ensuring consistency in the environment our code runs in.

  • Improvement of Test Experience
    Changes have been made to tests/GiiTestCase.php and tests/TestCase.php files, specifically to methods responsible for setting up and tearing down tests. These methods will now return a 'void' value (basically they will not return anything), making the process of running our tests smoother and reducing potential errors.

  • Codebase Clean-up
    We made changes to tests/bootstrap.php by removing a line of code that was no longer necessary. This makes our code easier to read and manage. Also, we eliminated the tests/compatibility.php file as it was no longer needed. These cleanup efforts help in maintaining an efficient and manageable codebase.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant