Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent -> Role Staffへの移行, 対応するテーブルとWriterの作成 #68

Merged
merged 12 commits into from
Feb 26, 2024

Conversation

Shion1305
Copy link
Member

@Shion1305 Shion1305 commented Feb 25, 2024

Property Value
Corresponding Issue #67
Assignee @Shion1305

PRで実装される機能

PRで修正される機能

  • RelationOrgUserで、同一の関連付けが複数存在する場合において、 Delete で一つのみしか削除されないバグの解消

  • 対応するテストケースの作成
    329d483

  • Staff テーブルの作成に伴い、 TypeMember を廃止。 86948cf

レビューをお願いしたいポイント

変更内容による実装の変更内容を一通り把握お願いします~

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 75.55556% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 48.66%. Comparing base (ff403f5) to head (46d459b).

Files Patch % Lines
svc/pkg/infra/reader/staff.go 69.23% 8 Missing ⚠️
svc/pkg/infra/writer/r_role_staff.go 78.94% 8 Missing ⚠️
svc/pkg/infra/reader/r_org_user.go 0.00% 4 Missing ⚠️
svc/pkg/infra/writer/staff.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   40.00%   48.66%   +8.66%     
==========================================
  Files          20       23       +3     
  Lines         970      976       +6     
==========================================
+ Hits          388      475      +87     
+ Misses        582      501      -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tomoyahiroe tomoyahiroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Shion1305 Shion1305 merged commit 4e5c4af into main Feb 26, 2024
5 checks passed
@Shion1305 Shion1305 deleted the issue/67 branch February 26, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🗃️ User情報からAdmin情報の切り離し
2 participants