-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent -> Role Staffへの移行, 対応するテーブルとWriterの作成 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 40.00% 48.66% +8.66%
==========================================
Files 20 23 +3
Lines 970 976 +6
==========================================
+ Hits 388 475 +87
+ Misses 582 501 -81 ☔ View full report in Codecov by Sentry. |
Shion1305
commented
Feb 25, 2024
Closed
3 tasks
tomoyahiroe
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRで実装される機能
PRで修正される機能
RelationOrgUserで、同一の関連付けが複数存在する場合において、 Delete で一つのみしか削除されないバグの解消
対応するテストケースの作成
329d483
Staff テーブルの作成に伴い、
TypeMember
を廃止。 86948cfレビューをお願いしたいポイント
変更内容による実装の変更内容を一通り把握お願いします~