Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: server not watched #77

Conversation

WilsonZiweiWang
Copy link
Contributor

Now launching the extension development host will watch both the client and the server, which it only watched the client previously.

Tracking No. : 14025

@WilsonZiweiWang WilsonZiweiWang self-assigned this Jan 25, 2024
@WilsonZiweiWang WilsonZiweiWang marked this pull request as draft January 25, 2024 21:53
The launch-client was only running watch:client which only reflects changes in the client.
Now it watches both client and server, no need to manually compile the server in case of changes.
Since we have defined the references in the tsconfig.json,
typescript will builds files in folders specified in the references option
Hence, watch:client and watch:server can be removed. The same goes for the
compile command.
@WilsonZiweiWang WilsonZiweiWang force-pushed the Task-14025-server-not-watched branch from 7b8e40e to b9837d9 Compare January 25, 2024 22:51
@WilsonZiweiWang WilsonZiweiWang marked this pull request as ready for review January 25, 2024 22:56
Copy link
Member

@idillon-sfl idillon-sfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, looks like something we should have done earlier

@WilsonZiweiWang WilsonZiweiWang merged commit 048eb64 into yoctoproject:staging Jan 26, 2024
2 checks passed
@WilsonZiweiWang WilsonZiweiWang deleted the Task-14025-server-not-watched branch January 26, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants