Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename StructureAsString to toTestString #656

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Rename StructureAsString to toTestString #656

merged 1 commit into from
Nov 1, 2023

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Nov 1, 2023

What this PR does / why we need it:

Rename StructureAsString to toTestString.

We originally used StructureAsString to represent a method for generating a string representation, primarily for debugging purposes. However, we've now decided to use struct to represent the structure for serialization. As a result, this commit updates the method name to align with our new naming convention, which is toTestString.

Which issue(s) this PR fixes:

Related to yorkie-team/yorkie-js-sdk#561

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (107498e) 48.89% compared to head (bd577ec) 48.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #656   +/-   ##
=======================================
  Coverage   48.89%   48.89%           
=======================================
  Files          69       69           
  Lines       10076    10076           
=======================================
  Hits         4927     4927           
  Misses       4629     4629           
  Partials      520      520           
Files Coverage Δ
pkg/document/crdt/tree.go 52.49% <100.00%> (ø)
pkg/document/time/ticket.go 88.88% <100.00%> (ø)
pkg/splay/splay.go 80.88% <100.00%> (ø)
pkg/document/crdt/array.go 33.33% <0.00%> (ø)
pkg/document/crdt/rga_tree_list.go 78.23% <0.00%> (ø)
pkg/document/crdt/text.go 59.30% <0.00%> (ø)
pkg/document/crdt/rga_tree_split.go 69.06% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins merged commit acc6703 into main Nov 1, 2023
1 check passed
@hackerwins hackerwins deleted the revise-logs branch November 1, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant