-
Overall time invested (not including breaks) is about four hours
-
Most of the time was invested in the view model. The view model itself contains all of the game logic, so it only makes sense that it would require more time. Other than that, the tests did not take as much time, but I did spend some time thinking about how to test certain things, and how to mock classes.
-
- Using MVVM: this is a default for me by now, as it makes testing a lot easier
- Using a dependency injector: this might seem like an overkill for a small app, but it did not require a lot of time and it made testing the ViewController much simpler. Also, dependency injection is crucial for testing as it allows us to easily use mocks.
- Using protocols for every class: this is again done for testing purposes. I also do not like using inheritance if I can avoid it, and with swift's protocol extension it has become a lot easier to avoid.
- Using reactive programming: for me personally it's a lot easier to write code this way
- Retrieving the json from the global queue: all potentially time consuming tasks should not be executed on the main thread.
-
- Not presenting any errors to the users, for example if there was a problem parsing the json, the user would not be aware of it as there will be no alert informing him.
- Second, the UX does not provide enough feedback to the user. For example, there's no animation that signals a buzzer was actually tapped. There's also no feedback for a wrong buzz, so a user might think that the buzzers are not working.
- Currently English and Spanish are 'hard coded' as native/training languages. This should be subjected to changes, as different users will want to use different languages.
-
I would act according to the list from the previous question.
-
Notifications
You must be signed in to change notification settings - Fork 0
yotamoo/WordBuzzer
Folders and files
Name | Name | Last commit message | Last commit date | |
---|---|---|---|---|
Repository files navigation
About
No description, website, or topics provided.
Resources
Stars
Watchers
Forks
Releases
No releases published
Packages 0
No packages published