TH-230: Add Products-by-Collection section #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eihabkhan
added
Ready for review
There was a problem hiding this comment.
Nice work Mr Eihab, here are some notes/suggestions to refine this section:
- maybe a scale effect on product image hover could work well?
- looks like
secondaryfits better thaniconfor the product button variant. - product titles need a
min-width. - global product settings don’t fully work (currently, only card style applies)
compactproduct style is missing a background- The
show morebutton isn’t visible in slides view style.
Comment on lines
16
to
25
| .yc-btn { | ||
| width: fit-content; | ||
| color: currentColor; | ||
| border: var(--product-card-border); | ||
| background-color: var(--product-card-background); | ||
|
|
||
| &:hover { | ||
| background-color: rgba(var(--product-card-foreground), 0.06); | ||
| } | ||
| } |
There was a problem hiding this comment.
check this file :hi
There was a problem hiding this comment.
Question is who's gonna merge first 😄
There was a problem hiding this comment.
rock paper scissors :sadpablo
There was a problem hiding this comment.
ibrilBadreddine
approved these changes
Jan 3, 2025
ibrilBadreddine
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
Ticket: TH-230.
Prerequisites
pnpm run releasetheme name + date + .zipQA Steps
Note
You might find some responsitivity issues when the section is in "Slides" mode. That's an issue with our core slider and will be fixed in the PR of this ticket.
Another issue arose where the contents of the slides are not responsive to user clicks (Ticket).