Adb parse device list add offline field improve #671
Conversation
| @@ -610,6 +616,7 @@ export namespace AdbServerClient { | |||
| model?: string | undefined; | |||
| device?: string | undefined; | |||
| transportId: bigint; | |||
| offline?:boolean | |||
There was a problem hiding this comment.
I'd like to use a single status field (and an enum) to replace offline and authenticating fields.
It might only contain Offline, Unauthorized and Online these three values initially, it can be extended later.
| @@ -169,11 +169,17 @@ export class AdbServerClient { | |||
| break; | |||
| } | |||
| } | |||
|
|
|||
| if(status === 'offline' && !product && !model && !device){ | |||
There was a problem hiding this comment.
Why is this needed? In which situation the device will (or won't) have these fields?
(these three fields are optional in the type definition)
There was a problem hiding this comment.
phone status online -> offline ,There will be no product,model and device fields
There was a problem hiding this comment.
Won't this exclude all offline devices?
There was a problem hiding this comment.
Yes, he doesn't exclude all offline devices, just filter out unwanted offline push messages
There was a problem hiding this comment.
Is there any concern？
There was a problem hiding this comment.
filter out unwanted offline push messages
Which ones are "wanted" and which ones are "unwanted"?
I'd like the method to return all devices, and let users decide what to do (they can filter by !product && !model && !device themselves.
There was a problem hiding this comment.
Previous versions will filter out offline information, which is not friendly to devices that need to listen in real time
There was a problem hiding this comment.
I still don't understand what you mean
There was a problem hiding this comment.
if (status !== "device" && status !== "unauthorized" ) {
continue;
}
offline push message Will be filtered
if (status !== "device" && status !== "unauthorized" && status !== "offline" ) {
continue;
}
There was a problem hiding this comment.
status === "offline" There will be multiple offline messages and not all of them will make sense
Adb parse device list add offline field improve