Fix the misuse of Rf_mkCharLenCE() (#71)

.github/workflows/wasm.yaml → .github/workflows/wasm_and_arm64.yaml

@@ -1,5 +1,3 @@
-# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
-# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
 on:
   push:
     branches: [main, master]
@@ -62,3 +60,16 @@ jobs:
         uses: yutannihilation/r-wasm-actions/build-rwasm@main
         with:
           packages: "local::./R-package"
+
+  # check at least it can build
+  build-arm64:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: dtolnay/rust-toolchain@stable
+        with:
+          targets: aarch64-unknown-linux-gnu
+
+      - name: Build
+        run: cargo build --target aarch64-unknown-linux-gnu

CHANGELOG.md

@@ -3,6 +3,11 @@
 <!-- next-header -->
 ## [Unreleased] (ReleaseDate)
 
+### Fixed bugs
+
+* Fix misuses of `Rf_mkCharLenCE()` which caused compilation error on ARM64
+  Linux.
+
 ## [v0.2.5] (2024-01-20)
 
 ### Breaking changes

src/lib.rs

@@ -10,6 +10,8 @@ pub mod protect;
 pub mod sexp;
 pub mod unwind_protect;
 
+use std::os::raw::c_char;
+
 pub use error::{Error, Result};
 pub use sexp::integer::{IntegerSexp, OwnedIntegerSexp};
 pub use sexp::list::{ListSexp, OwnedListSexp};
@@ -47,7 +49,7 @@ pub fn handle_error(e: crate::error::Error) -> SEXP {
         e => unsafe {
             let msg = e.to_string();
             let r_error = Rf_mkCharLenCE(
-                msg.as_ptr() as *const i8,
+                msg.as_ptr() as *const c_char,
                 msg.len() as i32,
                 cetype_t_CE_UTF8,
             );

src/sexp/string.rs

@@ -1,4 +1,5 @@
 use std::ffi::CStr;
+use std::os::raw::c_char;
 
 use savvy_ffi::{
     cetype_t_CE_UTF8, Rf_mkCharLenCE, Rf_xlength, R_CHAR, SET_STRING_ELT, SEXP, STRING_ELT, STRSXP,
@@ -96,7 +97,11 @@ unsafe fn str_to_charsxp(v: &str) -> crate::error::Result<SEXP> {
         Ok(savvy_ffi::R_NaString)
     } else {
         crate::unwind_protect(|| {
-            Rf_mkCharLenCE(v.as_ptr() as *const i8, v.len() as i32, cetype_t_CE_UTF8)
+            Rf_mkCharLenCE(
+                v.as_ptr() as *const c_char,
+                v.len() as i32,
+                cetype_t_CE_UTF8,
+            )
         })
     }
 }