-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Build server inside Dockerfile #1488
base: main
Are you sure you want to change the base?
Conversation
🤔 works on my machine with podman build \
--ulimit="nofile=65535:65535" \
--runtime runc \
-f ops/docker/jdk11-jammy/Dockerfile \
--build-context nomnoml="./nomnoml" \
--build-context vega="./vega" \
--build-context dbml="./dbml" \
--build-context wavedrom="./wavedrom" \
--build-context bytefield="./bytefield" \
--build-context kroki-src="." \
server |
Tests related to sockets are failing in the container. Not sure exactly why but it says:
Might be related to IPv6 not working as excepted with Docker m. Someone suggested to add You can probably try to add these options on the surefire plugin using: https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine |
f1987c6
to
16aff96
Compare
95dc6f7
to
9051072
Compare
Ok I just did the test locally with {
"ipv6": true,
"fixed-cidr-v6": "2001:db8:1::/64"
} and |
with buildah IPv6 would work https://github.com/copyrights/kroki/actions/runs/4547648299/jobs/8017796575#step:4:554 |
@copyrights are you still working on it? since we made quite a few changes you will need to rebase on the main branch. |
It seems the issue in github actions is closed. But I'll have to rebase to test it. I'll give it a shot. |
3a22690
to
f3db2fa
Compare
Nope, still no IPv6 support inside the github action. Otherwise the rebased version builds fine on systems with IPv6 enabled. |
resolves #1481