-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OnlineWardleyMaps as service #1684
base: main
Are you sure you want to change the base?
Conversation
…t, add showtitle as option (only for png)
Hi @ggrossetie , Is there any ETA for this? I would like to use this service in my workflow with kroki and asciidoc, but i am not sitting on hot shoes. Current workaround is to export a png and include it. I am fine with this, because it does not change frequently. But i love inline code to diagrams in combination with asciidoc. ;) |
I wouldn't say "major workings", you will need to make some ajustements to comply with the requirements. The specification goal is to describe how companion containers communicate with the gateway/main container.
It's on my TODO list but I've been quite busy! |
Hey, any progress? Can i help? I would like to see my changes in codebase, because i would like to promote it in my company for tech discussions. Have a great day. |
Hey,
this is my approach to add OnlineWardleyMaps in kroki as suggested in #179
Mostly it uses the diagramsnet logic plus some help from damonsk/onlinewardleymaps#170 and damonsk/onlinewardleymaps#75
Because i cannot build the java server (some issues with jdk or other stuff), i tested it with the following docker-compose.yml and add a smoke test for this service, too.
Because the first results looks promising, i create the PR now before i try to finetune the svg/png output, because out of the box it looks not as expected.
The dockerfile contains 3 separate apps:
OnlineWardleyMaps is not created to be used in this use case, but I think my approach should handle some major cases with changes upstream. But a complete rewrite would break my approach with git diffs, so there is a git commit sha in dockerfile, which should be updated from time to time.
I am happy to hear from you and get some feedback.
TODO:
Have a great day.
Edit:
If someone wants to use this already without to wait to merge, use the following snippet in your
docker-compose.yml