Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Zabbix V2.4 template schema #5

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

akayueh
Copy link

@akayueh akayueh commented Aug 24, 2016

  • Add Zabbix V2.4 template schema
  • LLD Index move to the discovery level
  • Remove index item in the prototype creation for LLD

Add support for Zabbix v2.4 template schema:

Zabbix template version

    -z, --zabbix_ver=2|3        Zabbix Template Schema Version (default: 3)
Support for Zabbix v2.4 LLD
- Index OID
Format code to align with the original
Missing ValueMap in item template for Zabbix v2.4
@@ -1,33 +1,20 @@
#!/usr/bin/perl
=pod

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove formatting/stylistic changes like these new-line removals

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come I can't see this extract line in mine?

@@ -354,11 +400,9 @@ =head1 SUBROUTINES
my $valuemaps = {};

=head2 utf8_santize

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and these...

add new-line
Copy link
Author

@akayueh akayueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Chris

I think all the issues you have request in the review has been fixed.

@cavaliercoder
Copy link
Collaborator

Hey Steven, I really want to accept this PR because it's a great feature and you've done a good job. Unfortunately your commits are still filled with line-break removals. In particular, this messes with Perl POD doc generation. Have a look at https://github.com/cavaliercoder/mib2zabbix/pull/5/files and you will see all the blank red lines.

It might be worth rewinding your changes to succinctly apply the required code changes only. Also beware that your code editor might be applying some formatting of its own design.

If I get a chance later, I'll merge your PR and unwind the line breaks for you.

@akayueh
Copy link
Author

akayueh commented Jan 24, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants