Add eslint config from create-react-app, include react-dom inside plugin

zackify · Apr 24, 2018 · 62edf10 · 62edf10
1 parent 6110daa
commit 62edf10
Show file tree

Hide file tree

Showing 7 changed files with 1,075 additions and 14 deletions.
diff --git a/config/base.webpack.js b/config/base.webpack.js
@@ -28,14 +28,20 @@ module.exports = ({
         exclude: /node_modules/,
         use: [
           {
-            loader: require.resolve('./loader'),
+            loader: require.resolve('babel-loader'),
+            options: babelOptions,
+          },
+          {
+            loader: require.resolve('eslint-loader'),
             options: {
-              pluginFolderName,
+              configFile: require.resolve('./eslint.js'),
             },
           },
           {
-            loader: require.resolve('babel-loader'),
-            options: babelOptions,
+            loader: require.resolve('./loader'),
+            options: {
+              pluginFolderName,
+            },
           },
         ],
       },

diff --git a/config/eslint.js b/config/eslint.js
@@ -0,0 +1,12 @@
+module.exports = {
+  extends: require.resolve('eslint-config-react-app'),
+  rules: {
+    'react/react-in-jsx-scope': 0,
+    'jsx-a11y/href-no-hash': 0,
+    'react/jsx-no-undef': [true, { allowGlobals: true }],
+  },
+  globals: {
+    wp: true,
+    React: true,
+  },
+};
diff --git a/config/loader.js b/config/loader.js
@@ -32,7 +32,7 @@ module.exports = function(source) {
       
       ${source}
 
-      Block.edit = props => wp.element.createElement(Import, {...props, load: () => import('./edit')});
+      Block.edit = props => <Import {...props} load={() => import('./edit')} />;
     
       if(!Block.save) Block.save = () => '';