Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix math panel overflow - closes #2056 #2084

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abitofevrything
Copy link
Contributor

The issue was originally caused by the math plugin only allowing the balloon to show up below the target. This pull request allows it to show on top as well, fixing the overflow issue.

@zadam
Copy link
Owner

zadam commented Jul 25, 2021

Hi, wouldn't it be better to fix this in the upstream - https://github.com/isaul32/ckeditor5-math ? It would then benefit all projects using this plugin ...

@abitofevrything
Copy link
Contributor Author

It seems the issue was added in this commit.

I will open an issue there and see if this is intentional.

@otisdog8
Copy link

Any update on this? I'm having the same issue and upstream for the project seems a bit dead as of right now. I can add extra lines to the end but would prefer the additional polish that comes with the software fixing it for me.

@zadam
Copy link
Owner

zadam commented Aug 26, 2021

Any update on this?

Not from my side.

@otisdog8
Copy link

Any chance of merging this?

@zadam
Copy link
Owner

zadam commented Aug 26, 2021

I still believe it would be much better to fix this upstream.

@otisdog8
Copy link

I agree that it would be better but upstream hasn't responded to the issue, and the owner of the repository hasn't had activity since May. This bug has been in trilium for at least two months and nothing has been done to fix it (except for a pull request that fixes the issue), and there are no drawbacks from at least merging this temporarily. I agree that it would be much better to fix this upstream, but we should still fix it in the meantime.

@chianti-ga
Copy link

chianti-ga commented Mar 13, 2023

Any updates about this?
The author of the plugin seems to be active again as he published a new release a month ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants