Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(express-tools): allow error handling for over ruling scopes #45

Merged
merged 1 commit into from
Apr 24, 2017

Conversation

ISO50
Copy link
Collaborator

@ISO50 ISO50 commented Apr 21, 2017

close #36

try {
precedenceErrorHandler(err, logger);
} catch (err) {
logger.error('Error while exectuting precedenceErrorHandler: ', err);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

BREAKING: signature of requireScopesMiddleware changed.

close #36
@ISO50
Copy link
Collaborator Author

ISO50 commented Apr 21, 2017

👍

Copy link
Collaborator

@bzums bzums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in requireScopesMiddleware should be documented in the readme right?, other then that it looks nice :)

@ISO50
Copy link
Collaborator Author

ISO50 commented Apr 24, 2017

See #46

@bzums
Copy link
Collaborator

bzums commented Apr 24, 2017

👍

@ISO50 ISO50 merged commit 3157ce9 into master Apr 24, 2017
@Retro64
Copy link
Collaborator

Retro64 commented Apr 24, 2017

👍

@bzums bzums deleted the 36-error-handling branch April 24, 2017 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[requireScopesMiddleware] is lacking error handling
3 participants