Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wraps chrome.storage with try/catch #802

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wraps chrome.storage with try/catch #802

wants to merge 1 commit into from

Conversation

Nantris
Copy link

@Nantris Nantris commented Jun 4, 2021

Fixes #767

@Nantris Nantris mentioned this pull request Jun 4, 2021
Open
@Nantris
Copy link
Author

Nantris commented Jun 4, 2021

If anyone knows the correct typeof for chrome.storage.sync that we could check against, that would be cleaner than my current solution.

@userlerueda
Copy link

@slapbox do you want to try to get this PR integrated in the new repo they posted to see if this can be fixed?
https://github.com/reduxjs/redux-devtools/blob/main/extension/src/browser/extension/options/syncOptions.ts

I can submit the change but since you were the one who spotted the problem.

@Nantris
Copy link
Author

Nantris commented Mar 1, 2022

@userlerueda if you have the bandwidth to resubmit this PR there, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors logged on startup in Electron 10
2 participants
@Nantris @userlerueda