chore: fix test_serialization_type

zama-ai · Jul 11, 2024 · 9a4fb52 · 9a4fb52
1 parent 77cbdd6
commit 9a4fb52
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/concrete/ml/pytest/utils.py b/src/concrete/ml/pytest/utils.py
@@ -612,11 +612,12 @@ def check_serialization(
     dump_method_to_test = [False]
 
     # If the given object provides a `dump`, `dumps` `dump_dict` method (which indicates that they
-    # are Concrete ML serializable classes), run the check using these as well
+    # are Concrete ML serializable classes) and are instantiated, run the check using these as well
     if (
         hasattr(object_to_serialize, "dump")
         and hasattr(object_to_serialize, "dumps")
         and hasattr(object_to_serialize, "dump_dict")
+        and not isinstance(object_to_serialize, type)
     ):
         dump_method_to_test.append(True)
 

diff --git a/tests/common/test_serialization.py b/tests/common/test_serialization.py
@@ -218,7 +218,6 @@ def test_serialize_numpy_array(dtype):
 )
 def test_serialize_type(value):
     """Test serialization of type objects (trusted by Skops)."""
-    value = torch.nn.modules.activation.ReLU
 
     check_serialization(value, type, check_str=False)