Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow QuantizedAdd produces_output_graph #398

Merged
merged 3 commits into from
Nov 29, 2023
Merged

feat: allow QuantizedAdd produces_output_graph #398

merged 3 commits into from
Nov 29, 2023

Conversation

jfrery
Copy link
Collaborator

@jfrery jfrery commented Nov 28, 2023 •
edited
Loading

@cla-bot cla-bot bot added the cla-signed label Nov 28, 2023
@jfrery jfrery changed the title feat: allow QuantizedAdd produces_output_graph + enable use of learning rate in FHE training feat: allow QuantizedAdd produces_output_graph Nov 28, 2023
@jfrery jfrery force-pushed the feat/add_raw_output_quantized_add branch from 10e8b93 to b15a690 Compare November 28, 2023 11:08
andrei-stoian-zama
andrei-stoian-zama reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far, just need some test!

src/concrete/ml/quantization/quantized_ops.py Show resolved Hide resolved
@jfrery jfrery marked this pull request as ready for review November 28, 2023 13:42
@jfrery jfrery requested a review from a team as a code owner November 28, 2023 13:42
kcelia
kcelia previously approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@kcelia kcelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

RomanBredehoft
RomanBredehoft previously approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@RomanBredehoft RomanBredehoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks a lot !

@jfrery jfrery dismissed stale reviews from RomanBredehoft and kcelia via a2ac830 November 28, 2023 15:53
@jfrery jfrery force-pushed the feat/add_raw_output_quantized_add branch from a2ac830 to 83aad09 Compare November 28, 2023 16:50
@github-actions GitHub Actions
Copy link

Coverage passed ✅

Coverage details 

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    6408      0   100%

51 files skipped due to complete coverage.

RomanBredehoft
RomanBredehoft reviewed Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@RomanBredehoft RomanBredehoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

RomanBredehoft
RomanBredehoft approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@RomanBredehoft RomanBredehoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@jfrery jfrery merged commit 0b57c71 into main Nov 29, 2023
9 checks passed
@jfrery jfrery deleted the feat/add_raw_output_quantized_add branch November 29, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanBredehoft RomanBredehoft RomanBredehoft approved these changes

@kcelia kcelia kcelia left review comments

@andrei-stoian-zama andrei-stoian-zama Awaiting requested review from andrei-stoian-zama

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jfrery @kcelia @RomanBredehoft @andrei-stoian-zama