chore: fixing OMP lib installation issues on intel mac for other python versions #612
Conversation
|
Draft: let me check it works fine again, after my experiments for HF. |
| else | ||
| echo "Please have a look to libraries libiomp5.dylib related to torch and then" | ||
| echo "apply appropriate fix" | ||
| exit -1 |
There was a problem hiding this comment.
because I guess it would be different for 3.11 as well!
|
@RomanBredehoft : you have an Intel Mac? in my understanding, the fixes were only needed for intel |
|
no but it was making the |
|
awesome, then! do we have an issue to close with this PR, then @RomanBredehoft ? |
|
no ! |
bcm-at-zama
force-pushed
the
fix_installation_issues_on_intel_mac_other_python
branch
from
c172520 to
c1c680b
Compare
|
@RomanBredehoft : did it fail for other python versions? I could have a look |
|
I did not try, python 3.10 was the default version and we don't need a sepcific python version for generating licenses but we currently support python 3.8 3.9 and 3.10 so you might also want to take a look at python 3.9 ! |
|
Looks to work. Unless you ask me @RomanBredehoft to have a look for another python version |
|
@bcm-at-zama checking python 3.9 could be worth indeed |
|
3.9 was already done in the script. So, we're good? |
| rm "${WHICH_VENV}"/lib/"${WHICH_PYTHON}"/site-packages/functorch/.dylibs/libiomp5.dylib | ||
| ln -s "${WHICH_VENV}"/lib/"${WHICH_PYTHON}"/site-packages/concrete/.dylibs/libomp.dylib "${WHICH_VENV}"lib/"${WHICH_PYTHON}"/site-packages/functorch/.dylibs/libiomp5.dylib | ||
| # The error is specific to python version | ||
| if [ "$PYTHON_VERSION" == "3.9" ] |
There was a problem hiding this comment.
@RomanBredehoft : 3.9
|
ok let me check with 3.8 |
|
Well, looks like for 3.10, it's still broken on my Mac intel, so it needs more work. Not sure when I have a look, let me create an issue |
|
OK finally it works on 3.10: I was able to
make force_licenses
./script/make_utils/licenses.sh --cp_version ""concrete-python==2.6.0-rc1"" --force_update
Doing licenses for user
MD5 of the poetry.lock for which dependencies have been listed: de67ec7ae864ce9d686569b7498a4ada
MD5 of the current poetry.lock: de67ec7ae864ce9d686569b7498a4ada
Make licenses with python Python 3.10.8
Looking in indexes: https://pypi.org/simple, https://repo.zama.ai/repository/internal-pypi/simple
Requirement already satisfied: pip in /private/tmp/tmp_venv/tmp_venv/lib/python3.10/site-packages (22.2.2)
Collecting pip
Using cached pip-24.0-py3-none-any.whl (2.1 MB)
Collecting wheel
Downloading wheel-0.43.0-py3-none-any.whl (65 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 65.8/65.8 kB 803.0 kB/s eta 0:00:00
Installing collected packages: wheel, pip
Attempting uninstall: pip
Found existing installation: pip 22.2.2
Uninstalling pip-22.2.2:
Successfully uninstalled pip-22.2.2
Successfully installed pip-24.0 wheel-0.43.0
Installing dependencies from lock file
Package operations: 75 installs, 1 update, 0 removals • Installing numpy (1.23.5) Installing the current project: concrete-ml (1.5.0) |
|
Let me do it with 3.11 |
|
How do I install 3.11 on my Mac, first |
|
I've installed 3.11 now |
|
But ie we don't support 3.11! |
|
That's with 3.8 that I've to check, my bad. |
…on version Works (tested) for 3.8, 3.9 and 3.10.
bcm-at-zama
force-pushed
the
fix_installation_issues_on_intel_mac_other_python
branch
from
c1c680b to
d8eff0a
Compare
|
```
python --version
Python 3.8.15
(.venv) ~/Documents/Zama/Git/concrete-ml % make force_licenses
./script/make_utils/licenses.sh --cp_version ""concrete-python==2.6.0-rc1"" --force_update
Doing licenses for user
MD5 of the poetry.lock for which dependencies have been listed: de67ec7ae864ce9d686569b7498a4ada
MD5 of the current poetry.lock: de67ec7ae864ce9d686569b7498a4ada
Make licenses with python Python 3.8.15
Looking in indexes: https://pypi.org/simple, https://repo.zama.ai/repository/internal-pypi/simple
Requirement already satisfied: pip in /private/tmp/tmp_venv/tmp_venv/lib/python3.8/site-packages (22.0.4)
Collecting pip
Using cached pip-24.0-py3-none-any.whl (2.1 MB)
Collecting wheel
Using cached wheel-0.43.0-py3-none-any.whl (65 kB)
Installing collected packages: wheel, pip
Attempting uninstall: pip
Found existing installation: pip 22.0.4
Uninstalling pip-22.0.4:
Successfully uninstalled pip-22.0.4
Successfully installed pip-24.0 wheel-0.43.0
Installing dependencies from lock file
Package operations: 76 installs, 1 update, 0 removals • Installing numpy (1.23.5) Installing the current project: concrete-ml (1.5.0) |
|
If the build is green, I would say: ready to go. |
bcm-at-zama
deleted the
fix_installation_issues_on_intel_mac_other_python
branch
Doing recompilation of our HF endpoints for python3.10 allowed me to see that this script was not working fine for 3.10. Still restricted to Intel Mac, I guess.
Tested on my machine for 3.8, 3.9 and 3.10
It will also be tested by the
check_licenseson the weekly buildcloses #https://github.com/zama-ai/concrete-ml-internal/issues/4386