Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix new concrete python target #727

Merged
merged 1 commit into from
Jun 13, 2024
Merged

chore: fix new concrete python target #727

merged 1 commit into from
Jun 13, 2024

Conversation

fd0r
Copy link
Collaborator

@fd0r fd0r commented Jun 13, 2024 •
edited by andrei-stoian-zama
Loading

@fd0r fd0r requested a review from a team as a code owner June 13, 2024 08:38
@cla-bot cla-bot bot added the cla-signed label Jun 13, 2024
RomanBredehoft
RomanBredehoft reviewed Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@RomanBredehoft RomanBredehoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! btw it closes https://github.com/zama-ai/concrete-ml-internal/issues/4495

RomanBredehoft
RomanBredehoft approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@RomanBredehoft RomanBredehoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanted to approve

@github-actions GitHub Actions
Copy link

Coverage passed ✅

Coverage details 

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    7878      0   100%

60 files skipped due to complete coverage.

@fd0r fd0r merged commit 40605d8 into main Jun 13, 2024
13 of 14 checks passed
@fd0r fd0r deleted the fix_cp_target branch June 13, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanBredehoft RomanBredehoft RomanBredehoft approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fd0r @RomanBredehoft