Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve link-checker and fix Tracer issue #939

Merged
merged 16 commits into from
Nov 7, 2024
Merged

Conversation

kcelia
Copy link
Collaborator

@kcelia kcelia commented Nov 4, 2024

In this PR:

  • I removed the issues 4563 and 4579, spotted by the bot and also discussed in slack
  • I refactored tests/torch/test_compile_torch.py::test_qat_import_check test to improve clarity and isolate Tracer._is_tracing
  • I moved AllZeroCNN to the torch_models file
  • Skip Temporarily: CNNOther (see issue)

closes https://github.com/zama-ai/concrete-ml-internal/issues/4667

@cla-bot cla-bot bot added the cla-signed label Nov 4, 2024
@kcelia kcelia marked this pull request as ready for review November 6, 2024 21:57
@kcelia kcelia requested a review from a team as a code owner November 6, 2024 21:57
Copy link

github-actions bot commented Nov 6, 2024

⚠️ Known flaky tests have been rerun ⚠️

One or several tests initially failed but were identified as known flaky. tests. Therefore, they have been rerun and passed. See below for more details.

Failed tests details

Known flaky tests that initially failed:

  • tests/torch/test_compile_torch.py::test_compile_torch_or_onnx_conv_networks[False-True-CNN_conv1d-relu]

Copy link

github-actions bot commented Nov 6, 2024

Coverage passed ✅

Coverage details

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    8414      0   100%

62 files skipped due to complete coverage.

Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@andrei-stoian-zama andrei-stoian-zama changed the title Remove solved issues: 4563 and 4579 Improve link-checker and fix Tracer issue Nov 7, 2024
@kcelia kcelia merged commit e396438 into main Nov 7, 2024
18 of 19 checks passed
@kcelia kcelia deleted the chore/remove_solved_issues branch November 7, 2024 08:57
@kcelia kcelia self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants