Make S3 triggers apply correctly with multiple stages using the same bucket #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SpareFoot/Zappa) into fix-s3-events-20210813 Migrating PR #2126 from Miserlou/Zappa to a new PR in zappa/Zappa.
|
zappa is currently tightly integrated with kappa, this may be a good starting point to migrate away from kappa. |
|
Hi there! Unfortunately, this PR has not seen any activity for at least 90 days. If the PR is still relevant to the latest version of Zappa, please comment within the next 10 days if you wish to keep it open. Otherwise, it will be automatically closed. |
|
Hi there! Unfortunately, this PR was automatically closed as it had not seen any activity in at least 100 days. If the PR is still relevant to the latest version of Zappa, please open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The S3EventSource handler from Kappa has been re-implemented to allow more precise addition and removal of S3 bucket event triggers allowing Zappa to work when multiple stages, app_functions, or even whole projects to apply and manage their own triggers on S3 buckets.
(This is an updated version of Miserlou/Zappa#2126, originally opened by @arcadecoffee)
GitHub Issues
fixes #872