Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zarr v3 dependency #182

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Add Zarr v3 dependency #182

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58f14ee
Add Zarr v3 dependency
ghidalgo3 Jul 9, 2024
5f9a88f
Add documentation
ghidalgo3 Jul 10, 2024
aa21299
Update docs/releases.rst
ghidalgo3 Jul 10, 2024
8c2a7a0
unvendor json_dumps
ghidalgo3 Jul 10, 2024
933e575
Revert "unvendor json_dumps"
ghidalgo3 Jul 11, 2024
e4534b6
Merge branch 'main' into guhidalgo/addzarrv3dependency
TomNicholas Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/releases.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ New Features
Breaking changes
~~~~~~~~~~~~~~~~

- Requires Zarr 3.0 (for :pull:`182`).
By `Gustavo Hidalgo <https://github.com/ghidalgo3>`_.

Deprecations
~~~~~~~~~~~~

Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ dependencies = [
"ujson",
"packaging",
"universal-pathlib",
"zarr>=3.0.0a0"
]

[project.optional-dependencies]
Expand Down
21 changes: 0 additions & 21 deletions virtualizarr/vendor/zarr/LICENSE.txt
View file
Open in desktop

This file was deleted.

Empty file removed virtualizarr/vendor/zarr/__init__.py
View file
Open in desktop
Empty file.
26 changes: 0 additions & 26 deletions virtualizarr/vendor/zarr/utils.py
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions virtualizarr/zarr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
import ujson # type: ignore
import xarray as xr
from pydantic import BaseModel, ConfigDict, field_validator

from virtualizarr.vendor.zarr.utils import json_dumps
from zarr.v2.util import json_dumps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid this import if possible. We are likely to remove the v2 namespace before the 3.0 release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert and continue to vendor this bit of code.


if TYPE_CHECKING:
pass
Expand Down