Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: context should be read-only #208

Merged
merged 2 commits into from
Mar 19, 2024
Merged

feat: context should be read-only #208

merged 2 commits into from
Mar 19, 2024

Conversation

tpluscode
Copy link
Contributor

I think we should prevent modification of pipeline context. Implementors should use variables or, in the future (#110), locals

Even though it'd not be a a legitimate use of barnard59, there was actually a test which directly modifies the context. In case anyone else did that, I consider this a breaking change

Copy link

changeset-bot bot commented Nov 22, 2023

🦋 Changeset detected

Latest commit: acfb7f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
barnard59-core Major
barnard59 Patch
barnard59-test-e2e Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.90%. Comparing base (4c79608) to head (acfb7f1).
Report is 25 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #208   +/-   ##
=======================================
  Coverage   84.90%   84.90%           
=======================================
  Files         172      172           
  Lines        6844     6844           
  Branches      102      102           
=======================================
  Hits         5811     5811           
  Misses       1031     1031           
  Partials        2        2           
Flag Coverage Δ
barnard59 81.20% <ø> (ø)
barnard59-base 47.97% <ø> (ø)
barnard59-core 90.92% <100.00%> (ø)
barnard59-csvw 80.21% <ø> (ø)
barnard59-cube 96.39% <ø> (ø)
barnard59-formats 32.63% <ø> (ø)
barnard59-ftp 85.38% <ø> (ø)
barnard59-graph-store 95.67% <ø> (ø)
barnard59-http 87.50% <ø> (ø)
barnard59-rdf 94.95% <ø> (ø)
barnard59-s3 100.00% <ø> (ø)
barnard59-shacl 52.17% <ø> (ø)
barnard59-sparql 91.11% <ø> (ø)
barnard59-validation 97.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpluscode tpluscode marked this pull request as ready for review March 19, 2024 08:06
@tpluscode tpluscode merged commit dc579f3 into master Mar 19, 2024
38 checks passed
@tpluscode tpluscode deleted the conext-ro branch March 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants