Skip to content

pczt: Define the structure and semantics of the PCZT format #852

pczt: Define the structure and semantics of the PCZT format

pczt: Define the structure and semantics of the PCZT format #852

Triggered via pull request December 4, 2024 00:59
@str4dstr4d
synchronize #1577
pczt-format
Status Failure
Total duration 3m 7s
Artifacts

audits.yml

on: pull_request
Vet Rust dependencies
2m 39s
Vet Rust dependencies
Check licenses
45s
Check licenses
Required status checks have passed
0s
Required status checks have passed
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 3 warnings
question mark operator is useless here: zcash_primitives/src/transaction/components/transparent/pczt/tx_extractor.rs#L33
error: question mark operator is useless here --> zcash_primitives/src/transaction/components/transparent/pczt/tx_extractor.rs:33:17 | 33 | / Ok(input 34 | | .script_sig 35 | | .clone() 36 | | .ok_or(TxExtractorError::MissingScriptSig)?) | |________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark = note: `-D clippy::needless-question-mark` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_question_mark)]` help: try removing question mark and `Ok()` | 33 ~ input 34 + .script_sig 35 + .clone() 36 + .ok_or(TxExtractorError::MissingScriptSig) |
this function has too many arguments (17/7): zcash_primitives/src/transaction/components/transparent/pczt/parse.rs#L22
error: this function has too many arguments (17/7) --> zcash_primitives/src/transaction/components/transparent/pczt/parse.rs:22:5 | 22 | / pub fn parse( 23 | | prevout_txid: [u8; 32], 24 | | prevout_index: u32, 25 | | sequence: Option<u32>, ... | 39 | | proprietary: BTreeMap<String, Vec<u8>>, 40 | | ) -> Result<Self, ParseError> { | |_________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `-D clippy::too-many-arguments` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
Vet Rust dependencies
Process completed with exit code 255.
Required status checks have passed
Process completed with exit code 1.
Check licenses
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Vet Rust dependencies
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Required status checks have passed
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636