Create new zcash_script crate that will contain logic for verifying Zcash transparent scripts.
#655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Zcash transparent scripts.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
===========================================
+ Coverage 51.52% 73.59% +22.06%
===========================================
Files 91 101 +10
Lines 8500 10825 +2325
===========================================
+ Hits 4380 7967 +3587
+ Misses 4120 2858 -1262 ☔ View full report in Codecov by Sentry. |
daira
reviewed
Oct 1, 2022
| stack.push(a.clone()); | ||
| stack.push(b.clone()); | ||
| stack.push(a); | ||
| stack.push(b); |
There was a problem hiding this comment.
All of these implementations could be made more concise with some helper functions ({push/pop}{1,2,3,4}).
nuttycom
added
the
S-in-progress
|
Subsumed by ZcashFoundation/zcash_script#158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very early WIP attempt at recreating
zcashd'sCScriptinterpreter and other logic needed to verify transparent scripts in an attempt to destroy this directory and help out the Zebra folks who maintain the actualzcash_scriptcrate which binds to our C++ codebase.