Fix and rename GitHub Action workflow #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
reviewed
Nov 22, 2023
daira
reviewed
Nov 22, 2023
This gets the Dockerfile behind the render workflow to build again. I also renamed the workflow because it described only building the PDF, but it also builds all the .html files.
The git push at the end didn't have permission to push back to the source repo, even if the PR author granted permission for contributors to push to the source branch.
|
@daira, can you take another look? I think it's ready, but I've made some changes worth reviewing. The PR description has been updated too. |
This was referenced May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice
This PR adds several PDFs to the repo, based on the enabled action and its tendency to update (or add missing) PDFs. Check it out. If these PDFs shouldn't be added, we can adjust the PR accordingly.