cover taproot-tweaked signing with integration tests #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ZcashFoundation#584 does not have any test coverage for taproot-tweaked signing.
This PR adds integration test coverage for signing with a commitment to a tapscript merkle root, proving that we can sign as a given group verifying key both with and without a tweak.
This chunk of code added to
ciphersuite_generic.rs
demonstrates how we can provide the 'effective' (tweaked) verifying key, AKA the 'taproot output key'. An observer can use it to verify signatures without the verifier knowing the tweak value used.I fixed a couple of minor mistakes in the first three commits. This commit specifically fixes the issue which @MatthewLM reported here.