* treat_skips_as_failures setting was fixed

* documentation was actualised
zebrunner · Jan 23, 2023 · 84791b6 · 84791b6
1 parent f871d4a
commit 84791b6
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -63,7 +63,7 @@ reporting:
     ms-teams-channels: automation, qa-team
     emails: example@example.com
   run:
-    treat_skips_as_failures: false
+    treat-skips-as-failures: false
     display-name: Nightly Regression Suite
     build: 1.12.1.96-SNAPSHOT
     environment: TEST-1

diff --git a/examples/example.robot b/examples/example.robot
@@ -21,12 +21,12 @@ Super long long long long long long long long long long long long long long long
 Open Google Chrome
     [Tags]
     ${caps}  Evaluate  {"enableVideo": True, "enableLogs": True, "enableVNC": True, "provider": "zebrunner"}
-    SeleniumLibrary.Open Browser    https://google.com  chrome  remote_url=https://{URL}/wd/hub  desired_capabilities=${caps}
+    SeleniumLibrary.Open Browser    https://google.com  chrome  remote_url=http://localhost:4444/wd/hub  desired_capabilities=${caps}
     SeleniumLibrary.Close Browser
 
 Open Firefox
     [Tags]
     ${caps}  Evaluate  {"enableVideo": True, "enableLogs": True, "enableVNC": True, "provider": "zebrunner"}
-    SeleniumLibrary.Open Browser    https://google.com  firefox  remote_url=https://{URL}/wd/hub  desired_capabilities=${caps}
+    SeleniumLibrary.Open Browser    https://google.com  firefox  remote_url=http://localhost:4444/wd/hub  desired_capabilities=${caps}
     Should Be True  2 + 2 == 5
     SeleniumLibrary.Close Browser
diff --git a/src/robotframework_zebrunner/api/models.py b/src/robotframework_zebrunner/api/models.py
@@ -66,7 +66,7 @@ class Config:
 class TestRunConfigModel(CamelModel):
     environment: Optional[str] = None
     build: Optional[str] = None
-    treat_skips_as_failures: bool = True
+    treat_skips_as_failures: bool
 
 
 class MilestoneModel(CamelModel):

diff --git a/src/robotframework_zebrunner/listener.py b/src/robotframework_zebrunner/listener.py
@@ -78,6 +78,7 @@ def _start_test_run(self, data: running.TestSuite) -> Optional[int]:
             config=TestRunConfigModel(
                 environment=settings.run.environment,
                 build=settings.run.build,
+                treat_skips_as_failures=settings.run.treat_skips_as_failures,
             ),
             ci_context=resolve_ci_context(),
         )

diff --git a/src/robotframework_zebrunner/settings.py b/src/robotframework_zebrunner/settings.py
@@ -18,6 +18,7 @@ class TestRunSettings(BaseModel):
     build: Optional[str] = None
     environment: Optional[str] = None
     context: Optional[str] = None
+    treat_skips_as_failures: bool = True
 
 
 class ServerSettings(BaseModel):