Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable inline completions in Vim normal mode (#22439)
This is harmful for user experience and at best requires a user setting. This was committed as part of #21739 however that change had no relevant release notes and no relevant settings. The issue #22343 shows how this can result in user experience regression: deleting a text fragment can reinsert it back, and it's thus unclear if the deletion has even worked. Maybe this can be reenabled in some very restrictive setup, and put behind a setting, but it can't be unconditional. Completions should activate when the user signals intent of entering code - for example, if instead of `de` to delete a fragment, I press `ce` to replace it, I would naturally expect inline completions to show up. Note: The linked PR added more code in vim crate to refresh inline completions in normal mode. I'm keeping that code around in this commit, so that this can be the minimal fix to the linked issue -- with the assumption that maybe there's some way in the future to reenable this in a subset of cases that don't result in confusing / broken UX. If that is not true the code might need further cleanup. Let me know if you'd rather see removal of those changes in this PR as well. Closes #22343. Release Notes: - Fixes inline completions showing up in Vim normal mode.
- Loading branch information