Skip to content

Commit

Permalink
Revert "Use livekit's Rust SDK instead of their swift SDK (#13343)" (#…
Browse files Browse the repository at this point in the history
…20809)

Issues found:

* audio does not work well with various set-ups using USB
* switching audio during initial join may leave the client with no audio
at all
* audio streaming is done on the main thread, beachballing certain
set-ups
* worse screenshare quality (seems that there's no dynamic scaling
anymore, compared to the Swift SDK)

This reverts commit 1235d08.

Release Notes:

- N/A
  • Loading branch information
SomeoneToIgnore authored Nov 18, 2024
1 parent 59a355d commit d92166f
Show file tree
Hide file tree
Showing 48 changed files with 3,596 additions and 4,285 deletions.
6 changes: 0 additions & 6 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@ rustflags = ["-C", "link-arg=-fuse-ld=mold"]
linker = "clang"
rustflags = ["-C", "link-arg=-fuse-ld=mold"]

[target.aarch64-apple-darwin]
rustflags = ["-C", "link-args=-Objc -all_load"]

[target.x86_64-apple-darwin]
rustflags = ["-C", "link-args=-Objc -all_load"]

# This cfg will reduce the size of `windows::core::Error` from 16 bytes to 4 bytes
[target.'cfg(target_os = "windows")']
rustflags = ["--cfg", "windows_slim_errors"]
Loading

0 comments on commit d92166f

Please sign in to comment.