Skip to content

Commit

Permalink
Use zstd without dynamic linking due to musl usage (#19627)
Browse files Browse the repository at this point in the history
Due to leaning towards `musl` builds, unit features for `zstd` and link
it statically too for Zed.


https://github.com/gyscos/zstd-rs/blob/bfe1e34f593c2427e9dc35f1b98d06788174711f/zstd-safe/zstd-sys/build.rs#L260
shows that `ZSTD_SYS_USE_PKG_CONFIG` env var can be used to return this
behavior.

Release Notes:

- N/A
  • Loading branch information
SomeoneToIgnore authored Oct 23, 2024
1 parent 291af66 commit e87d5e1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions crates/zed/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@ winresource = "0.1"

[target.'cfg(target_os = "linux")'.dependencies]
ashpd.workspace = true
# We don't use zstd in the zed crate, but we want to add this feature when compiling a desktop build of Zed
zstd = { workspace = true, features = [ "pkg-config" ] }

[dev-dependencies]
call = { workspace = true, features = ["test-support"] }
Expand Down

0 comments on commit e87d5e1

Please sign in to comment.