Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text invisible with CommitMono #21271

Open
1 task done
undecided opened this issue Nov 28, 2024 · 5 comments
Open
1 task done

Text invisible with CommitMono #21271

undecided opened this issue Nov 28, 2024 · 5 comments
Labels
bug [core label] font Font feedback for readability, size, style, etc linux

Comments

@undecided
Copy link

undecided commented Nov 28, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

After auto-updating to v0.163.2, suddently all the text in my buffers disappeared.

Workaround: Change font from CommitMono - even invalid font names fallback to a valid font, CommitMono appears to be the only font that is breaking on my machine
Reproduce: Choose CommitMono. Checked font in other apps, and the font loads correctly there.
Tried downloading and installing a fresh copy from https://commitmono.com - fallback loaded until I restarted zed, then all the glyphs disappear again

Environment

Zed: v0.163.2 (Zed)
OS: Linux X11 linuxmint 22
Memory: 62.6 GiB
Architecture: x86_64
GPU: Intel(R) Xe Graphics (TGL GT2) || Intel open-source Mesa driver || Mesa 24.0.9-0ubuntu0.2

(also happens on v0.164.0 (Zed Preview) )

If applicable, add mockups / screenshots to help explain present your vision of the feature

image
(I should note for clarity, the shadow of text behind the file tree is a different project on a window that hasn't been redrawn since I changed the font back to commit mono - just bleeds through due to window transparency)

If applicable, attach your Zed.log file to this issue.

Zed.log (I've just added a snippet of the log - it's all identical, with the exception of the `GlyphId(x)` ). I'd guess there's one for every character it has tried to render)
2024-11-28T09:53:11.81495478Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(1063), font_size: 12 px, subpixel_variant: Point { x: 1, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. }
2024-11-28T09:53:11.814989064Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(1055), font_size: 12 px, subpixel_variant: Point { x: 1, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. }
2024-11-28T09:53:11.815060832Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(565), font_size: 12 px, subpixel_variant: Point { x: 1, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. }
2024-11-28T09:53:11.815092887Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(874), font_size: 12 px, subpixel_variant: Point { x: 1, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. }
2024-11-28T09:53:11.815124361Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(906), font_size: 12 px, subpixel_variant: Point { x: 0, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. }
2024-11-28T09:53:11.81515559Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(906), font_size: 12 px, subpixel_variant: Point { x: 0, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. }
2024-11-28T09:53:11.815186751Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(906), font_size: 12 px, subpixel_variant: Point { x: 0, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. }
2024-11-28T09:53:11.81521901Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(906), font_size: 12 px, subpixel_variant: Point { x: 0, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. }
2024-11-28T09:53:11.815249645Z [ERROR] no image for RenderGlyphParams { font_id: FontId(5), glyph_id: GlyphId(906), font_size: 12 px, subpixel_variant: Point { x: 0, y: 1 }, scale_factor: 2.0, is_emoji: false } in font Font { id: ID(InnerId(407v1)), .. }
@undecided undecided added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Nov 28, 2024
@CharlesChen0823
Copy link
Contributor

CharlesChen0823 commented Nov 28, 2024

this might relate #19772 i guess


update:
this is introduce by

@david-umd
Copy link

i'm having the same issue with commit mono, have never ran into this on any other situation. used to work fine in zed until updating recently.
zed's log looks the same as the original poster.

environment:
Zed: v0.163.2 (Zed)
OS: Linux Wayland arch unknown
Memory: 15.3 GiB
Architecture: x86_64
GPU: Intel(R) UHD Graphics 620 (WHL GT2) || Intel open-source Mesa driver || Mesa 24.2.7-arch1.1

@JosephTLyons JosephTLyons added linux font Font feedback for readability, size, style, etc linux-x11 Linux X11 and removed triage Maintainer needs to classify the issue admin read Pending admin review linux-x11 Linux X11 labels Dec 3, 2024
@CharlesChen0823
Copy link
Contributor

I had found the way to fixed the problem. will send a pr, but don't known if zed team will accepts.

@florian-obernberger
Copy link

Just built the latest version (v0.166.1) from source using the provided scripts/install-linux and I am facing the same issue: Using CommitMono makes the text be lovely invisible

@LSeelig
Copy link

LSeelig commented Jan 22, 2025

Switching fonts fixed this (for now). Is anyone else experiencing this with 169?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] font Font feedback for readability, size, style, etc linux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants