Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: Lock cosmic-text dependency swash version #21457

Closed

Conversation

CharlesChen0823
Copy link
Contributor

Closes #21271

in #20842, the version of swash was bump from 0.1.18 to 0.1.19. the swash dependency skrifa, which introduce read-fonts bump version from 0.20 to 0.22. then cause current problem.

And current the fast method is downgrade version of swash, and then lock the version.

for simple, i just bump the version of cosmic-text and then lock the version of swash in cosmic-text.

not sure if this is acceptable.

Release Notes:

  • Fixed the Text invisible with CommitMono

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 3, 2024
@CharlesChen0823 CharlesChen0823 changed the title linux: lock cosmic-text dependency swash version linux: Lock cosmic-text dependency swash version Dec 3, 2024
@mikayla-maki
Copy link
Contributor

Thank you for this PR but we would rather not depend on an unofficial fork of CosmicText that isn't in our organization.

Could you re-open this PR, but with Cargo's patch feature or some such? https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html

@CharlesChen0823
Copy link
Contributor Author

I don't known how cargo patch feature work..., you can fork the CosmicText and then lock the swash version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text invisible with CommitMono
2 participants