Add fs::MTime newtype to encourage != instead of >
#20830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
mgsloan
force-pushed
the
mtime-newtype
branch
from
b4f41fb to
4d799dd
Compare
maxdeviant
reviewed
Nov 18, 2024
maxdeviant
reviewed
Nov 18, 2024
crates/fs/src/fs.rs
Outdated
| @@ -27,13 +27,15 @@ use futures::{future::BoxFuture, AsyncRead, Stream, StreamExt}; | |||
| use git::repository::{GitRepository, RealGitRepository}; | |||
| use gpui::{AppContext, Global, ReadGlobal}; | |||
| use rope::Rope; | |||
| use serde::Deserialize; | |||
| use serde_derive::Serialize; | |||
There was a problem hiding this comment.
Is there a particular reason we need a separate serde_derive import instead of using Serialize from serde (which should already have the derive feature)?
There was a problem hiding this comment.
Ah, good point! Not sure why it ended up like this, I think was the auto-import suggestion
mgsloan
force-pushed
the
mtime-newtype
branch
5 times, most recently
from
c1917d5 to
1495ab1
Compare
See ["mtime comparison considered harmful"](https://apenwarr.ca/log/20181113) for details of why comparators other than equality/inequality should not be used with mtime.
mgsloan
force-pushed
the
mtime-newtype
branch
from
1495ab1 to
4892769
Compare
mgsloan
changed the title
fs::MTime newtype and fix assumptions of temporal orderingfs::MTime newtype to encourage != instead of >
Anthony-Eid
pushed a commit
to Anthony-Eid/zed
that referenced
this pull request
Nov 22, 2024
…ies#20830) See ["mtime comparison considered harmful"](https://apenwarr.ca/log/20181113) for details of why comparators other than equality/inequality should not be used with mtime. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See "mtime comparison considered harmful" for details of why comparators other than equality/inequality should not be used with mtime.
Release Notes: